fix: add missing agent-context extension entries to Cline _expected_files#2797
Merged
Merged
Conversation
…iles TestClineIntegration._expected_files() overrides the base-class version but was not updated when the bundled agent-context extension files were added to test_integration_base_markdown.py, causing test_complete_file_inventory_sh and test_complete_file_inventory_ps to fail. Fixes github#2796
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes failing Cline integration inventory tests by aligning TestClineIntegration._expected_files() with the base markdown integration test mixin after the bundled agent-context extension files were added.
Changes:
- Added the 8 missing bundled
agent-contextextension file paths toTestClineIntegration._expected_files()so the Cline-specific override matches the base expected inventory.
Show a summary per file
| File | Description |
|---|---|
| tests/integrations/test_integration_cline.py | Updates Cline’s overridden expected file list to include the bundled agent-context extension files, preventing “extra files” inventory failures. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2796
TestClineIntegration._expected_files()overrides the base-class version but was never updated when the bundledagent-contextextension files were added totest_integration_base_markdown.py. This causedtest_complete_file_inventory_shandtest_complete_file_inventory_psto fail with 8 "extra" files reported.Change
Added the 8 missing agent-context extension file entries to
TestClineIntegration._expected_files()intests/integrations/test_integration_cline.py, mirroring what the base class already lists:.specify/extensions.yml.specify/extensions/.registry.specify/extensions/agent-context/README.md.specify/extensions/agent-context/agent-context-config.yml.specify/extensions/agent-context/commands/speckit.agent-context.update.md.specify/extensions/agent-context/extension.yml.specify/extensions/agent-context/scripts/bash/update-agent-context.sh.specify/extensions/agent-context/scripts/powershell/update-agent-context.ps1Testing
All 3345 tests pass (1 skipped).