Skip tests where ssh-keygen cannot create a fingerprint for DSA/DSS keys. #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eys. Newer versions of OpenSSH no longer support the legacy algorithm DSA/DSS. When ssh-keygen is used to get the fingerprint for a DSA key, those OpenSSH versions will fail. When ssh-keygen is unable to generate a fingerprint, we will skip the test.
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (3)
spec/spec_helper.rb:27
- Returning nil without logging a warning or error message when ssh-keygen output is empty can make it difficult to diagnose issues during test failures.
return nil if out.strip.empty?
spec/public_key_spec.rb:22
- [nitpick] Skipping tests when fingerprints are not available may hide potential issues. Consider logging a warning or error instead.
skip "Fingerprint not available" if md5_fpr.nil?
spec/public_key_spec.rb:27
- [nitpick] Skipping tests when fingerprints are not available may hide potential issues. Consider logging a warning or error instead.
skip "Fingerprint not available" if sha256_fpr.nil?
Tip: Turn on automatic Copilot reviews for this repository to get quick feedback on every pull request. Learn more
fletchto99
reviewed
Dec 13, 2024
fletchto99
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer versions of OpenSSH no longer support the legacy algorithm DSA/DSS. When ssh-keygen is used to get the fingerprint for a DSA key, those OpenSSH versions will fail. When ssh-keygen is unable to generate a fingerprint, we will skip the test.
Long term we should probably deprecate and remove DSA/DSS in the same steps as OpenSSH, but this gets our tests back to green as a first step.