Skip to content
This repository was archived by the owner on Sep 9, 2025. It is now read-only.

[Java] Move lost test into package test folder #243

Merged
merged 2 commits into from
May 9, 2023
Merged

[Java] Move lost test into package test folder #243

merged 2 commits into from
May 9, 2023

Conversation

@hendrikvanantwerpen
Copy link
Contributor

@hendrikvanantwerpen hendrikvanantwerpen commented Mar 29, 2023

No description provided.

@hendrikvanantwerpen hendrikvanantwerpen requested a review from a team as a code owner March 29, 2023 09:49
rnkaufman
rnkaufman approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@rnkaufman rnkaufman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Though I think we can actually remove this test entirely - we capture the same behavior here

@hendrikvanantwerpen
Copy link
Contributor Author

hendrikvanantwerpen commented May 8, 2023

Thanks for spotting that! I'll just throw it out then :)

@hendrikvanantwerpen hendrikvanantwerpen merged commit 1d5094d into main May 9, 2023
@hendrikvanantwerpen hendrikvanantwerpen deleted the move-test branch May 9, 2023 08:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@rnkaufman rnkaufman rnkaufman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

java

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hendrikvanantwerpen @rnkaufman