Preemptively add a version number to the query history json file#1168
Merged
aeisenberg merged 2 commits intomainfrom Feb 25, 2022
Merged
Preemptively add a version number to the query history json file#1168aeisenberg merged 2 commits intomainfrom
aeisenberg merged 2 commits intomainfrom
Conversation
Since we are now storing query history on disk, we will need to handle situations where versions change. For now, there is only version 1. In the future, we may need to make breaking changes to this format and we need the flexibility to detect and possibly handle different versions. In this case, users don't often downgrade their vscode versions, so most likely, we only need to be forward compatible. Ie- we need to handle moving from v1 to v2, but not the other way around.
charisk
approved these changes
Feb 25, 2022
Contributor
charisk
left a comment
charisk
left a comment
There was a problem hiding this comment.
Good stuff! Just need to revert a small change that has crept in.
Co-authored-by: Charis Kyriakou <charisk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we are now storing query history on disk, we will need to handle
situations where versions change. For now, there is only version 1. In
the future, we may need to make breaking changes to this format and we
need the flexibility to detect and possibly handle different versions.
In this case, users don't often downgrade their vscode versions, so
most likely, we only need to be forward compatible. Ie- we need to
handle moving from v1 to v2, but not the other way around.
Checklist
ready-for-doc-reviewlabel there.