Conversation
aeisenberg
approved these changes
Mar 4, 2022
Contributor
aeisenberg
left a comment
There was a problem hiding this comment.
Looks good. My main comment about trying your best to display malformed source locs can be delayed until later.
Contributor
Author
|
There is a bit of a delay with releasing a new version of Primer React so I'll go ahead and merge this PR since none of the RC issues seem to be affecting us. I'll come back and upgrade the package versions once a new version is released. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to read code flow information from SARIF files and render those in the Web View.
A few notes:
Checklist
N/A:
ready-for-doc-reviewlabel there.