Skip to content

Add support for showing code flows#1187

Merged
charisk merged 1 commit intomainfrom
charisk/code-flows
Mar 9, 2022
Merged

Add support for showing code flows#1187
charisk merged 1 commit intomainfrom
charisk/code-flows

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Mar 4, 2022

Adds the ability to read code flow information from SARIF files and render those in the Web View.

A few notes:

  • I've used an RC version of the Primer React library to take advantage of some of the new menu/overlay stuff. I don't intend to merge the PR until the final version is released (see Primer React v35 RC - Technical Preview primer/react#1918).
  • As discussed previously, we need a better solution for the validation aspect of SARIF data.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk requested review from a team as code owners March 4, 2022 16:59
Copy link
Copy Markdown
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. My main comment about trying your best to display malformed source locs can be delayed until later.

Comment thread extensions/ql-vscode/src/remote-queries/sarif-processing.ts
Comment thread extensions/ql-vscode/src/remote-queries/sarif-processing.ts
Comment thread extensions/ql-vscode/src/remote-queries/view/CodePaths.tsx
Comment thread extensions/ql-vscode/src/remote-queries/view/CodePaths.tsx
@charisk
Copy link
Copy Markdown
Contributor Author

charisk commented Mar 9, 2022

There is a bit of a delay with releasing a new version of Primer React so I'll go ahead and merge this PR since none of the RC issues seem to be affecting us. I'll come back and upgrade the package versions once a new version is released.

@charisk charisk merged commit 2c50043 into main Mar 9, 2022
@charisk charisk deleted the charisk/code-flows branch March 9, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants