Skip to content

Disable the open-vsx-publish job#1192

Merged
aeisenberg merged 1 commit intomainfrom
aeisenberg/disable-openvsx-deploy
Mar 9, 2022
Merged

Disable the open-vsx-publish job#1192
aeisenberg merged 1 commit intomainfrom
aeisenberg/disable-openvsx-deploy

Conversation

@aeisenberg
Copy link
Copy Markdown
Contributor

It is failing, blocked on #1085

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

It is failing, blocked on #1085
@aeisenberg aeisenberg requested a review from a team as a code owner March 7, 2022 18:20
Copy link
Copy Markdown
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a mysterious test failure, but otherwise LGTM!

needs: build
environment: publish-open-vsx
runs-on: ubuntu-latest
if: 1 == 0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

briefly considers whether 1 is ever equal to 0 🤔 😅

@aeisenberg aeisenberg merged commit af53a02 into main Mar 9, 2022
@aeisenberg aeisenberg deleted the aeisenberg/disable-openvsx-deploy branch March 9, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants