Skip to content

Rename ColumnValue to CellValue#1196

Merged
charisk merged 1 commit intomainfrom
charisk/rename-type
Mar 9, 2022
Merged

Rename ColumnValue to CellValue#1196
charisk merged 1 commit intomainfrom
charisk/rename-type

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Mar 9, 2022

ColumnValue seems to represent the value of a specific cell in a column, so to me it seems that CellValue is a better name for it.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk requested a review from a team as a code owner March 9, 2022 11:48
@charisk charisk merged commit 8e2d18d into main Mar 9, 2022
@charisk charisk deleted the charisk/rename-type branch March 9, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aeisenberg aeisenberg aeisenberg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@charisk @aeisenberg