Skip to content

Rename analysis alert results#1197

Merged
charisk merged 3 commits intomainfrom
charisk/rename-alert-results
Mar 10, 2022
Merged

Rename analysis alert results#1197
charisk merged 3 commits intomainfrom
charisk/rename-alert-results

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Mar 9, 2022

We will soon be introducing support for non-alert results, so I've renamed results to alertResults to disambiguate between the two.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk requested a review from a team as a code owner March 9, 2022 15:08
@charisk charisk requested a review from a team as a code owner March 9, 2022 15:26
@aeisenberg
Copy link
Copy Markdown
Contributor

For local queries, we use the term InterpretedResults. Can you use the same term here instead of AlertResults?

@charisk
Copy link
Copy Markdown
Contributor Author

charisk commented Mar 9, 2022

For local queries, we use the term InterpretedResults. Can you use the same term here instead of AlertResults?

Ah thanks, yeah better keep it consistent! What is the equivalent for non-alert queries? Is it RawResults?

Copy link
Copy Markdown
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, raw results.

@charisk charisk merged commit d052ddb into main Mar 10, 2022
@charisk charisk deleted the charisk/rename-alert-results branch March 10, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants