Get database sha from result index#1205
Merged
shati-patel merged 1 commit intogithub:mainfrom Mar 15, 2022
Merged
Conversation
This was referenced Mar 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to be able to link from remote query results to the exact file that's being analysed (i.e. the correct GitHub URL for the repository + the exact commit SHA that the database was built from).
https://github.com/dsp-testing/qc-run2/pull/639 adds this to the result index, and this PR reads the SHA and adds it to the
AnalysisSummary. (If no SHA is found, we useHEADas a fall back)We don't use the SHA anywhere yet, but we'll need it in the webview soon. (I "tested" the change by setting some breakpoints and checking the variables, but there's no visible change 🤷🏽 )
Checklist
N/A - internal only 🤫
ready-for-doc-reviewlabel there.