Fix highlight region end column calculation#1210
Merged
Conversation
rneatherway
approved these changes
Mar 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a recent PR we took advantage of the
parseSarifRegion()fromsarif-utils.tsfor remote queries. However,parseSarifRegionassumes the region will be used by VS Code tooling (the editor) so it offsets it by 1. This made highlights in the remote queries view miss out on the last character.Ideally we should be updating
parseSarifRegionto be more generic but that would have been a slightly bigger change than I would have liked right now.Checklist
N/A:
ready-for-doc-reviewlabel there.