Skip to content

Fix highlight region end column calculation#1210

Merged
charisk merged 2 commits intomainfrom
charisk/highlight-end-column
Mar 16, 2022
Merged

Fix highlight region end column calculation#1210
charisk merged 2 commits intomainfrom
charisk/highlight-end-column

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Mar 16, 2022

In a recent PR we took advantage of the parseSarifRegion() from sarif-utils.ts for remote queries. However, parseSarifRegion assumes the region will be used by VS Code tooling (the editor) so it offsets it by 1. This made highlights in the remote queries view miss out on the last character.

Ideally we should be updating parseSarifRegion to be more generic but that would have been a slightly bigger change than I would have liked right now.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk requested a review from a team as a code owner March 16, 2022 09:20
@charisk charisk requested a review from a team as a code owner March 16, 2022 09:25
@charisk charisk merged commit 8cc2f59 into main Mar 16, 2022
@charisk charisk deleted the charisk/highlight-end-column branch March 16, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants