Skip to content

Change public occurrences of "remote queries"#1215

Merged
shati-patel merged 5 commits intomainfrom
shati-patel/rename-remote-queries
Mar 17, 2022
Merged

Change public occurrences of "remote queries"#1215
shati-patel merged 5 commits intomainfrom
shati-patel/rename-remote-queries

Conversation

@shati-patel
Copy link
Copy Markdown
Contributor

@shati-patel shati-patel commented Mar 16, 2022

Renames "remote queries" to "variant analysis" (see internal issue).

I've covered any user-facing messages/settings/commands but I've deliberately left most internal things unchanged, like the file structure, names of types, tests etc

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

const panel = (this.panel = Window.createWebviewPanel(
'remoteQueriesView',
'Remote Query Results',
'CodeQL Query Results',
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the Figma designs, this should've been "CodeQL Query Results" anyway (to match the local results view).

Happy to change to "Variant Analysis Results" if people prefer!

@shati-patel shati-patel marked this pull request as ready for review March 16, 2022 15:40
@shati-patel shati-patel requested review from a team as code owners March 16, 2022 15:40
Copy link
Copy Markdown
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just got a test failure to fix.

@shati-patel shati-patel marked this pull request as draft March 17, 2022 09:58
@shati-patel shati-patel marked this pull request as ready for review March 17, 2022 09:58
@shati-patel shati-patel merged commit 2a8a90b into main Mar 17, 2022
@shati-patel shati-patel deleted the shati-patel/rename-remote-queries branch March 17, 2022 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants