Skip to content

Use variable for highlighting code#1216

Merged
shati-patel merged 1 commit intomainfrom
shati-patel/highlight-light-theme
Mar 17, 2022
Merged

Use variable for highlighting code#1216
shati-patel merged 1 commit intomainfrom
shati-patel/highlight-light-theme

Conversation

@shati-patel
Copy link
Copy Markdown
Contributor

Code highlighting looked funny in light mode 🙈
image

I've used a variable instead, so it currently looks like this in dark/light mode:
image
or
image

My choice of --vscode-editor-findMatchHighlightBackground was fairly random, but it looks plausible 😅

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@shati-patel shati-patel requested a review from a team as a code owner March 16, 2022 18:06
Copy link
Copy Markdown
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that looks much better! 😄

@shati-patel shati-patel marked this pull request as draft March 17, 2022 09:58
@shati-patel shati-patel marked this pull request as ready for review March 17, 2022 09:58
@shati-patel shati-patel enabled auto-merge (squash) March 17, 2022 10:01
@shati-patel shati-patel merged commit f36048c into main Mar 17, 2022
@shati-patel shati-patel deleted the shati-patel/highlight-light-theme branch March 17, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants