Allow a custom branch name in settings file#1226
Merged
robertbrignull merged 2 commits intomainfrom Mar 21, 2022
Merged
Conversation
shati-patel
approved these changes
Mar 21, 2022
Contributor
shati-patel
left a comment
There was a problem hiding this comment.
Thanks, looks good! Just a few minor comments 💭
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The variant analysis API endpoint accepts a parameter to control the branch of an action used as part of running the queries. This is for internal testing of changes. The option is not available to users who aren't github staff. But it is useful and it'll be more useful if we could set it from the preferences.
I tested it briefly and it seems to be working correctly and passing the value from the preferences file to the API method.
Checklist
ready-for-doc-reviewlabel there.