Skip to content

Allow a custom branch name in settings file#1226

Merged
robertbrignull merged 2 commits intomainfrom
robertbrignull/allow-custom-action-branch
Mar 21, 2022
Merged

Allow a custom branch name in settings file#1226
robertbrignull merged 2 commits intomainfrom
robertbrignull/allow-custom-action-branch

Conversation

@robertbrignull
Copy link
Copy Markdown
Contributor

The variant analysis API endpoint accepts a parameter to control the branch of an action used as part of running the queries. This is for internal testing of changes. The option is not available to users who aren't github staff. But it is useful and it'll be more useful if we could set it from the preferences.

I tested it briefly and it seems to be working correctly and passing the value from the preferences file to the API method.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
    • No visible changes
  • Issues have been created for any UI or other user-facing changes made by this pull request.
    • No user-facing changes
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.
    • Not required

@robertbrignull robertbrignull requested review from a team as code owners March 18, 2022 16:32
Copy link
Copy Markdown
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! Just a few minor comments 💭

Comment thread extensions/ql-vscode/src/config.ts Outdated
Comment thread extensions/ql-vscode/src/config.ts Outdated
@robertbrignull robertbrignull merged commit 72aa4f0 into main Mar 21, 2022
@robertbrignull robertbrignull deleted the robertbrignull/allow-custom-action-branch branch March 21, 2022 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants