Allow GitHub URL as well as NWO#1241
Merged
shati-patel merged 2 commits intomainfrom Mar 29, 2022
Merged
Conversation
aeisenberg
reviewed
Mar 28, 2022
Contributor
aeisenberg
left a comment
aeisenberg
left a comment
There was a problem hiding this comment.
One minor thing about adding a comment, and once that is in, this can be merged.
| if (uri.scheme !== 'https') { | ||
| return; | ||
| } | ||
| if (uri.authority !== 'github.com' && uri.authority !== 'www.github.com') { |
Contributor
There was a problem hiding this comment.
In the future, we may need to support GHES. Nothing to do now, but something to keep in mind.
| } | ||
| return; | ||
| } catch (e) { | ||
| return; |
Contributor
There was a problem hiding this comment.
Please add a comment here about why it's ok to ignore a caught error.
Contributor
Author
There was a problem hiding this comment.
Thanks! Good point 😃
aeisenberg
approved these changes
Mar 28, 2022
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small follow-up to #1229.
When downloading a GH database, you can now enter a GitHub URL as well as a "name with owner" (since this is slightly easier to copy-paste). I've used similar logic as the
looksLikeLgtmUrlfunction.Checklist
N/A - internal only.
ready-for-doc-reviewlabel there.