Add source map support and clean test dependencies#1260
Merged
aeisenberg merged 1 commit intomainfrom Mar 31, 2022
Merged
Conversation
aeisenberg
force-pushed
the
aeisenberg/source-map-support
branch
from
700773a to
5a1b32c
Compare
1. Source map support means that stack traces will point to the *.ts file instead of the generated *.js file 2. Cleaning test dependencies means moving all mocha and chai registration into the respective index files and removing unnecessary imports.
aeisenberg
force-pushed
the
aeisenberg/source-map-support
branch
from
5a1b32c to
35e9da8
Compare
shati-patel
approved these changes
Mar 31, 2022
Contributor
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
Thanks, this looks good! 😃
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
file instead of the generated *.js file
registration into the respective index files and removing unnecessary
imports.
Development only. No user facing changes.
Checklist
ready-for-doc-reviewlabel there.