Use the repos defined in the query result instead of the query#1268
Merged
Use the repos defined in the query result instead of the query#1268
Conversation
shati-patel
approved these changes
Apr 4, 2022
Contributor
shati-patel
left a comment
There was a problem hiding this comment.
Looks good! 🌼
Just a comment about a minor behaviour change: Do we now only count repositories with results? E.g.
I don't think this is necessarily a problem, especially for security researchers running on loads of repos at once! But (in future) we might want to change the design slightly, so we're not showing the number of repos with results in two places? 🤔
shati-patel
approved these changes
Apr 4, 2022
Contributor
shati-patel
left a comment
There was a problem hiding this comment.
Ignore my previous comment! That turned out to be a different issue 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


In order to support system defined repo lists (see linked internal issue) we need to stop relying on the repository names being available to us on the query object, but instead get that information from the query result.
This PR updates a couple of uses of the repo lists to be using the query result instead of the query.
Checklist
N/A:
ready-for-doc-reviewlabel there.