Add support for system defined repository lists#1271
Merged
Conversation
aeisenberg
reviewed
Apr 4, 2022
| * @param repoSelection The selection to check. | ||
| * @returns A boolean flag indicating if the selection is valid or not. | ||
| */ | ||
| export function isInvalidSelection(repoSelection: RepositorySelection): boolean { |
Contributor
There was a problem hiding this comment.
minor: I find the double negative here a little harder to parse mentally. Could you change this to isValidSelection and invert all the booleans?
Contributor
|
I like this approach. |
aeisenberg
approved these changes
Apr 5, 2022
Contributor
aeisenberg
left a comment
aeisenberg
left a comment
There was a problem hiding this comment.
Looks good. Two comments, which you can take or leave.
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for system defined repository lists (top 10, top 100, etc.)
Checklist
N/A:
ready-for-doc-reviewlabel there.