Skip to content

Update dependency-review.yml#1280

Merged
aeisenberg merged 2 commits intogithub:mainfrom
febuiles:patch-2
Apr 7, 2022
Merged

Update dependency-review.yml#1280
aeisenberg merged 2 commits intogithub:mainfrom
febuiles:patch-2

Conversation

@febuiles
Copy link
Copy Markdown

@febuiles febuiles commented Apr 6, 2022

This PR updates the dependency-review.yml workflow to use the a public URL and version. Pushing as a draft, will mark as ready for review once we've GA'd.

Tracking issue: https://github.com/github/dependency-graph/issues/1019

name: 'Dependency Review'
on:
- pull_request
- workflow_dispatch
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is workflow_dispatch available for this? I like being able to run manually.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aeisenberg We filter the type of event: https://github.com/actions/dependency-review-action/blob/e2f8306beb67a0ad1d5fefc49bf74937e5bf231e/src/main.ts#L10-L14. I think this would prevent you from using workflow_dispatch here, is that understanding correct?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aeisenberg I re-added workflow_dispatch since it wasn't causing any harm, feel free to experiment with it manually!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I honestly don't remember if it was working. I'll try it out later and remove if it's broken.

@febuiles febuiles marked this pull request as ready for review April 7, 2022 11:35
@febuiles febuiles requested a review from a team as a code owner April 7, 2022 11:35
@aeisenberg
Copy link
Copy Markdown
Contributor

Note sure why the build failed. Logs aren't there. It's possibly a GH actions hiccup.

@febuiles
Copy link
Copy Markdown
Author

febuiles commented Apr 7, 2022

@aeisenberg are you able to re-run the Ubuntu check to see if it goes green? I don't see the option here to re-run, error doesn't seem related to the Action though.

@aeisenberg aeisenberg enabled auto-merge April 7, 2022 15:32
@aeisenberg aeisenberg merged commit a3deec7 into github:main Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants