Display nicer names for github-downloaded databases#1294
Merged
aeisenberg merged 1 commit intomainfrom Apr 19, 2022
Merged
Conversation
shati-patel
reviewed
Apr 14, 2022
Contributor
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
Much nicer, thanks 😄 A few minor changes, since this is still an internal-only feature.
| ## [UNRELEASED] | ||
|
|
||
| - Re-enable publishing to open-vsx. [#1285](https://github.com/github/vscode-codeql/pull/1285) | ||
| - Databases downloaded from GitHub have a more user friendly name. These databases will now be named `{org}/{repo}` instead of `codeql-db`. [#1294](https://github.com/github/vscode-codeql/pull/1294) |
Contributor
There was a problem hiding this comment.
No need for a changelog entry - downloading from GitHub is still a hidden feature (due to the MRVA API being restricted)
| { | ||
| "view": "codeQLDatabases", | ||
| "contents": "Add a CodeQL database:\n[From a folder](command:codeQLDatabases.chooseDatabaseFolder)\n[From an archive](command:codeQLDatabases.chooseDatabaseArchive)\n[From a URL (as a zip file)](command:codeQLDatabases.chooseDatabaseInternet)\n[From LGTM](command:codeQLDatabases.chooseDatabaseLgtm)" | ||
| "contents": "Add a CodeQL database:\n[From GitHub](command:codeQLDatabases.chooseDatabaseGithub)\n[From a folder](command:codeQLDatabases.chooseDatabaseFolder)\n[From an archive](command:codeQLDatabases.chooseDatabaseArchive)\n[From a URL (as a zip file)](command:codeQLDatabases.chooseDatabaseInternet)\n[From LGTM](command:codeQLDatabases.chooseDatabaseLgtm)" |
Contributor
There was a problem hiding this comment.
As above! Unless there's a way to make this button canary-only, we should hide it until the feature is more widely available.
Contributor
Author
There was a problem hiding this comment.
Hmmm...no way to do that. I'll remove. I forgot it is still a canary-only feature.
| ignoreSourceArchive: isQLTestDatabase, | ||
| // displayName is only set if a user explicitly renames a database | ||
| displayName: undefined, | ||
| // If a diaplayName is not passed in, the basename of folder containing the database is used. |
Contributor
There was a problem hiding this comment.
Minor :)
Suggested change
| // If a diaplayName is not passed in, the basename of folder containing the database is used. | |
| // If a displayName is not passed in, the basename of the folder containing the database is used. |
This will now name databases downloaded from github based on their nwo. Also, this adds a new button to suggest downloading from github in an empty databases view.
aeisenberg
force-pushed
the
aeisenberg/db-name-github
branch
from
2b6add2 to
8f2d865
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will now name databases downloaded from github based on their nwo.
Also, this adds a new button to suggest downloading from github in an
empty databases view.
Replace this with a description of the changes your pull request makes.
Checklist
ready-for-doc-reviewlabel there.