Conversation
shati-patel
approved these changes
Apr 21, 2022
Contributor
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
Thanks! That looks nicer 💅🏽 😁
aeisenberg
reviewed
Apr 21, 2022
| return <> | ||
| {codeFlow.threadFlows.map((threadFlow, index) => | ||
| <div key={`thread-flow-${index}`}> | ||
| <div key={`thread-flow-${index}`} style={{ maxWidth: '55em' }}> |
Contributor
There was a problem hiding this comment.
@charisk I haven't tried this out, but please make sure the width of the thread-flow works appropriately with different widths of the editor. For example, here https://github.com/github/vscode-codeql/pull/1246/files#diff-a4999bb18eefc6082a9ea9682424992d6ffd30071624f21da9bf75a7fee5073bR18 We need to use a calc to make sure there is no overflow. Maybe this works fine...I'm just trying to make sure.
Contributor
Author
There was a problem hiding this comment.
Yep I tested this before raising the PR. We should probably add some padding on the right too but at least it doesn't expand forever now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After:
Checklist
N/A:
ready-for-doc-reviewlabel there.