Skip to content

Upgrade node version minimum requirement#1326

Merged
charisk merged 2 commits intomainfrom
charisk/node-upgrade
May 3, 2022
Merged

Upgrade node version minimum requirement#1326
charisk merged 2 commits intomainfrom
charisk/node-upgrade

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Apr 29, 2022

I believe we're expecting use of v15 and above so I've updated the engine definition.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk requested a review from a team as a code owner April 29, 2022 12:00
Copy link
Copy Markdown
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, makes sense! 🚢

@edoardopirovano
Copy link
Copy Markdown
Contributor

Should we not also be checking in an updated package-lock.json?

Copy link
Copy Markdown
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a little strange that we have "@types/node": "^16.11.25" in dev dependencies, but the minimum node version is 15. Can we synchronize the two? And also, the package lock should be updated as @edoardopirovano mentions.

@aeisenberg
Copy link
Copy Markdown
Contributor

We also need to make sure that we run the internal integration tests using the same version of node. This is something I can take care of.

@charisk charisk merged commit e10d2ae into main May 3, 2022
@charisk charisk deleted the charisk/node-upgrade branch May 3, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants