Skip to content

Add new support for resolve ml-models#1363

Merged
aeisenberg merged 2 commits intomainfrom
aeisenberg/resolve-ml-model
May 31, 2022
Merged

Add new support for resolve ml-models#1363
aeisenberg merged 2 commits intomainfrom
aeisenberg/resolve-ml-model

Conversation

@aeisenberg
Copy link
Copy Markdown
Contributor

@aeisenberg aeisenberg commented May 25, 2022

The new support will be available in the next
release of the CLI, most likely 2.9.3, 2.10.0.

This change requires the query to be run to be
passed in to the call to resolve ml-models.

Not a user facing change.

Checklist

  • [n/a] CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

The new support will be available in the next
release of the CLI, most likely 2.9.3,

This change requires the query to be run to be
passed in to the call to resolve ml-models.
@aeisenberg aeisenberg requested a review from a team as a code owner May 25, 2022 00:25
@aeisenberg aeisenberg requested a review from henrymercer May 25, 2022 00:26
Copy link
Copy Markdown
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo the CLI version constraint

Comment thread extensions/ql-vscode/src/cli.ts Outdated
Change version where precise ml-model resolution was introduced.
@aeisenberg
Copy link
Copy Markdown
Contributor Author

Confirmed the version will be 2.10.0.

@aeisenberg aeisenberg enabled auto-merge May 31, 2022 01:32
@aeisenberg aeisenberg merged commit 6b4be93 into main May 31, 2022
@aeisenberg aeisenberg deleted the aeisenberg/resolve-ml-model branch May 31, 2022 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants