Add ability of running MRVA against a whole org#1372
Merged
Conversation
aeisenberg
reviewed
Jun 1, 2022
Contributor
There was a problem hiding this comment.
Looks sensible overall, but I think we need to change from "Organization" to "owner" and "User/Organization".
I started adding comments for things that need to change, but I think it's pretty straight forward to figure it out.
And a minor comment is that we generally use US spelling for public facing strings.
aeisenberg
reviewed
Jun 13, 2022
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
aeisenberg
approved these changes
Jun 14, 2022
Contributor
aeisenberg
left a comment
There was a problem hiding this comment.
Looks good to me. We need to avoid merging until the related backend change is deployed.
Contributor
Author
Thanks - yep, it's why it's still in draft :D I'll test once the back-end changes are in and publish the PR if all is well. |
shati-patel
reviewed
Jun 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Give the users the option to enter an organisation they're looking to run their MRVA against.
Checklist
N/A:
ready-for-doc-reviewlabel there.