Skip to content

Add ability of running MRVA against a whole org#1372

Merged
charisk merged 8 commits intomainfrom
charisk/mrva-all-repos-of-org
Jun 21, 2022
Merged

Add ability of running MRVA against a whole org#1372
charisk merged 8 commits intomainfrom
charisk/mrva-all-repos-of-org

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Jun 1, 2022

Give the users the option to enter an organisation they're looking to run their MRVA against.

image

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

Copy link
Copy Markdown
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible overall, but I think we need to change from "Organization" to "owner" and "User/Organization".

I started adding comments for things that need to change, but I think it's pretty straight forward to figure it out.

And a minor comment is that we generally use US spelling for public facing strings.

Comment thread extensions/ql-vscode/src/pure/helpers-pure.ts Outdated
Comment thread extensions/ql-vscode/src/pure/helpers-pure.ts Outdated
Comment thread extensions/ql-vscode/src/remote-queries/repository-selection.ts Outdated
Comment thread extensions/ql-vscode/src/remote-queries/repository-selection.ts Outdated
Comment thread extensions/ql-vscode/src/remote-queries/repository-selection.ts Outdated
charisk and others added 2 commits June 14, 2022 09:43
Copy link
Copy Markdown
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We need to avoid merging until the related backend change is deployed.

@charisk
Copy link
Copy Markdown
Contributor Author

charisk commented Jun 15, 2022

Looks good to me. We need to avoid merging until the related backend change is deployed.

Thanks - yep, it's why it's still in draft :D I'll test once the back-end changes are in and publish the PR if all is well.

@charisk charisk marked this pull request as ready for review June 15, 2022 14:55
@charisk charisk requested review from a team as code owners June 15, 2022 14:55
Comment thread extensions/ql-vscode/src/pure/helpers-pure.ts Outdated
@charisk charisk merged commit 0ebff2d into main Jun 21, 2022
@charisk charisk deleted the charisk/mrva-all-repos-of-org branch June 21, 2022 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants