Use base styling for MRVA results font#1375
Merged
elenatanasoiu merged 1 commit intomainfrom Jun 13, 2022
Merged
Conversation
aeisenberg
reviewed
Jun 1, 2022
extensions/ql-vscode/src/remote-queries/view/FileCodeSnippet.tsx
Outdated
Show resolved
Hide resolved
elenatanasoiu
force-pushed
the
elenatanasoiu/adjust-font-on-results
branch
from
290a1c6 to
6e54daa
Compare
shati-patel
reviewed
Jun 1, 2022
Contributor
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
Thank you for the PR ⚡ 😸
I've left a couple of suggestions, mainly to clarify the original issue!
extensions/ql-vscode/src/remote-queries/view/FileCodeSnippet.tsx
Outdated
Show resolved
Hide resolved
extensions/ql-vscode/src/remote-queries/view/FileCodeSnippet.tsx
Outdated
Show resolved
Hide resolved
elenatanasoiu
force-pushed
the
elenatanasoiu/adjust-font-on-results
branch
from
6e54daa to
9cccbe9
Compare
It's been pointed out that MRVA results are hard to read as the font is small and narrowly spaced. It also doesn't match the font type normally used in source files. We can instead switch to using the font-family used by VS Code itself and increase the font size from `x-small` to `small` for code snippets.
elenatanasoiu
force-pushed
the
elenatanasoiu/adjust-font-on-results
branch
from
9cccbe9 to
5f8802f
Compare
aeisenberg
approved these changes
Jun 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's been pointed out that MRVA results are hard to read as the font is
small and narrowly spaced. It also doesn't match the font type normally
used in source files.
We can instead switch to using the
font-familyvalues we've defined inour base styles and increase the font size from
x-smalltosmall.Before
After
Checklist
ready-for-doc-reviewlabel there.