Fail fast if codeql repo is missing from the workspace#1400
Merged
elenatanasoiu merged 2 commits intomainfrom Jun 23, 2022
Merged
Fail fast if codeql repo is missing from the workspace#1400elenatanasoiu merged 2 commits intomainfrom
elenatanasoiu merged 2 commits intomainfrom
Conversation
Contributor
adityasharad
left a comment
adityasharad
left a comment
There was a problem hiding this comment.
Makes sense. Minor clarification: the codeql repo provides the CodeQL libraries, not the CLI.
elenatanasoiu
changed the title
elenatanasoiu
force-pushed
the
elenatanasoiu/check-for-codeql-folder-in-workspace
branch
from
245c902 to
ac5e906
Compare
aeisenberg
reviewed
Jun 22, 2022
Contributor
Author
|
Thanks for reviewing @adityasharad & @aeisenberg 💐 |
elenatanasoiu
force-pushed
the
elenatanasoiu/check-for-codeql-folder-in-workspace
branch
from
ac5e906 to
0489537
Compare
aeisenberg
approved these changes
Jun 22, 2022
In order to run our cli-integration tests, we're required to have a local copy of the codeql CLI repo. We can then run the tests by running the `Launch Integration Tests - With CLI` task from inside VS Code. (See CONTRIBUTING.md for details.) If we don't have the CLI repo cloned locally or we're not pointing to it in `launch.json`, we don't get a clear indication of what the problem is. The tests will still attempt to run. Let's fail fast instead and add an actionable error message to the output.
elenatanasoiu
force-pushed
the
elenatanasoiu/check-for-codeql-folder-in-workspace
branch
from
0489537 to
e0b2aa9
Compare
elenatanasoiu
deleted the
elenatanasoiu/check-for-codeql-folder-in-workspace
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to run our cli-integration tests, we're required to have a
local copy of the
github/codeqlrepo. We can then run the tests byrunning the
Launch Integration Tests - With CLItask from insideVS Code.
(See CONTRIBUTING.md for details.)
If we don't have the repo cloned locally or we're not pointing to it
in
launch.json, we don't get a clear indication of what the problem is.The tests will still attempt to run.
Let's fail fast instead and add an actionable error message to the output.
We're also updating
CONTRIBUTING.mdto make it a bit friendlier fornewcomers.