MRVA: Display alert text even if location is undefined#1407
Merged
Conversation
shati-patel
approved these changes
Jun 28, 2022
Contributor
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
Thanks, code changes looks good to me, and local preview seems sensible!
(Feel free to wait for a second opinion though, since we partly paired on this 😂)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show the alert message, even if the location of a result isn't defined. See internal issue for details. I've also done some minor refactoring/renaming to make things easier to read.
Before:
After:
Checklist
N/A:
ready-for-doc-reviewlabel there.