Ensure completed flag is set on remote query history items#1434
Merged
Conversation
elenatanasoiu
approved these changes
Jul 19, 2022
shati-patel
approved these changes
Jul 19, 2022
Contributor
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
Works locally and looks good to me! Thanks for thinking of "patching" older items too 🩹
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Query history items have a
completedflag as well as a status that could beCompleted. I believe the reason we have acompletedflag is historical. This PR makes sure thecompletedflag is set if the status is Completed for remote query history items and also adds some logic to patch up existing data.Checklist
N/A:
ready-for-doc-reviewlabel there.