Add implements and signature to syntax highlighting#1468
Merged
dbartol merged 2 commits intogithub:mainfrom Aug 23, 2022
dbartol:dbartol/pmod-highlight/work
Merged
Add implements and signature to syntax highlighting#1468dbartol merged 2 commits intogithub:mainfrom dbartol:dbartol/pmod-highlight/work
implements and signature to syntax highlighting#1468dbartol merged 2 commits intogithub:mainfrom
dbartol:dbartol/pmod-highlight/work
Conversation
dbartol
added
bug
aeisenberg
reviewed
Aug 23, 2022
Contributor
aeisenberg
left a comment
aeisenberg
left a comment
There was a problem hiding this comment.
Hmmm...signature is working as expected, but implements is not. Is something wrong with this syntax?
| - match: '(?#simple-id)' | ||
| name: entity.name.type.namespace.ql | ||
|
|
||
| # The `extends` clause of a class definition. |
Contributor
There was a problem hiding this comment.
Suggested change
| # The `extends` clause of a class definition. | |
| # The `implements` clause of a class definition. |
Contributor
Author
There was a problem hiding this comment.
Doesn't implements only apply to modules?
Contributor
Author
There was a problem hiding this comment.
(I admit that would have been more apparent had I remembered to change the comment...)
aeisenberg
approved these changes
Aug 23, 2022
Contributor
aeisenberg
left a comment
aeisenberg
left a comment
There was a problem hiding this comment.
Ah...yes. That works now. Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds syntax highlighting for the new, still-experimental "parameterized modules" feature in the QL language.
signatureis added as an "annotation keyword", highlighted only if it appears before a module, class, or predicate declaration.implementsis added as a context-sensitive keyword, available only within a module defintion (but outside the module body).