Fix data not being loaded in MRVA results panel#1472
Merged
Conversation
When the MRVA results panel is closed (so the panel gets disposed) and opened again, it would not load the MRVA data (such as whether a query has already been downloaded). This fixes it by also resetting the internal state of whether the panel is loaded when the panel is disposed.
shati-patel
approved these changes
Aug 24, 2022
Contributor
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
Nice, this seems to fix the bug 😻 Thanks! ⚡
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the MRVA results panel is closed (so the panel gets disposed) and opened again, it would not load the MRVA data (such as whether a query has already been downloaded). This fixes it by also resetting the internal state of whether the panel is loaded when the panel is disposed.
Checklist
ready-for-doc-reviewlabel there.