Merged
Conversation
This will add a new abstract class that implements the creation of the panel and webview to reduce duplication across the different interface managers.
aeisenberg
reviewed
Aug 26, 2022
Contributor
aeisenberg
left a comment
aeisenberg
left a comment
There was a problem hiding this comment.
Quick review. Haven't tried this out yet. Looks good so far.
| ...(config.additionalOptions?.localResourceRoots ?? []), | ||
| Uri.file(tmpDir.name), | ||
| Uri.file(path.join(ctx.extensionPath, 'out')), | ||
| Uri.file(path.join(ctx.extensionPath, 'node_modules/@vscode/codicons/dist')), |
Contributor
There was a problem hiding this comment.
In your other PR, you have codicons being loaded for the MRVA view only. Here it looks like you are loading for all the views. I think what you have here is fine (since I think we should use codicons in the other views where appropriate), but I just want to make sure I understand this properly.
Member
Author
There was a problem hiding this comment.
You might have gotten this from the previous PR already, but it's indeed correct that we are now loading it for all the views.
aeisenberg
approved these changes
Aug 30, 2022
Contributor
aeisenberg
left a comment
aeisenberg
left a comment
There was a problem hiding this comment.
Tested this locally. Seems to be working. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will add a new abstract class that implements the creation of the panel and webview to reduce duplication across the different interface managers.
Checklist
ready-for-doc-reviewlabel there.