Skip to content

Avoid prompting for upgrades when they wouldn't be prompted.#1500

Merged
alexet merged 1 commit intogithub:mainfrom
alexet:alexet/no-prompt-upgrade-non-destuctive
Sep 7, 2022
Merged

Avoid prompting for upgrades when they wouldn't be prompted.#1500
alexet merged 1 commit intogithub:mainfrom
alexet:alexet/no-prompt-upgrade-non-destuctive

Conversation

@alexet
Copy link
Copy Markdown

@alexet alexet commented Sep 7, 2022

We prompt for destructive upgrades once at the start of running multiple queries so the user doesn't get repeated prompts but with non-destructive they wouldn't any way and it would be worse. This also moves the version check to live with all the other version checks.

I pulled this out of #1498 because it isn't directly related.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@alexet alexet force-pushed the alexet/no-prompt-upgrade-non-destuctive branch from d35d81c to 4cc832b Compare September 7, 2022 13:03
@alexet alexet marked this pull request as ready for review September 7, 2022 13:16
@alexet alexet requested a review from a team as a code owner September 7, 2022 13:16
Copy link
Copy Markdown
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A nice little cleanup.

@alexet alexet merged commit 7c4eac8 into github:main Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants