Open variant analysis view after submission#1553
Merged
Conversation
| // The "openVariantAnalysisView" command is internal-only. | ||
| ctx.subscriptions.push( | ||
| commandRunner('codeQL.openVariantAnalysisView', async (variantAnalysisId: number) => { | ||
| const variantAnalysisView = new VariantAnalysisView(ctx, variantAnalysisId); |
Contributor
There was a problem hiding this comment.
What's the reason for having an internal-only command?
Member
Author
There was a problem hiding this comment.
This mostly just follows the existing examples in the extension. For example, codeQL.copyRepoList and codeQL.autoDownloadRemoteQueryResults are both internal-only commands. I would suspect these were implemented as such so they can be easily called from anywhere in the extension.
Contributor
There was a problem hiding this comment.
Cool, thanks for explaining 👍
This will open the variant analysis view after the variant analysis has been submitted. It will also show a notification that the analysis has been submitted, which includes the query name.
koesie10
force-pushed
the
koesie10/show-variant-analysis-view
branch
from
d6e2ea4 to
b5b3474
Compare
elenatanasoiu
approved these changes
Sep 30, 2022
koesie10
force-pushed
the
koesie10/show-variant-analysis-view
branch
from
b3fcd4f to
d33b07b
Compare
elenatanasoiu
approved these changes
Oct 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will open the variant analysis view after the variant analysis has been submitted. It will also show a notification that the analysis has been submitted, which includes the query name.
Checklist
ready-for-doc-reviewlabel there.