Skip to content

Remove mentions of lgtm.com from README#1558

Merged
jf205 merged 1 commit intomainfrom
lgtm-update
Sep 30, 2022
Merged

Remove mentions of lgtm.com from README#1558
jf205 merged 1 commit intomainfrom
lgtm-update

Conversation

@jf205
Copy link
Copy Markdown
Contributor

@jf205 jf205 commented Sep 30, 2022

LGTM.com is due to be deprecated (https://github.com/orgs/community/discussions/29534) so this PR updates the readme for the new 'Download database from GitHub' feature.

See also github/vscode-codeql-starter#132.

@jf205 jf205 requested a review from a team as a code owner September 30, 2022 11:50
1. Select the language for the database you want to download (only required if the project has databases for multiple languages).
1. Once the CodeQL database has been imported, it is displayed in the Databases view.

For more information, see [Choosing a database](https://codeql.github.com/docs/codeql-for-visual-studio-code/analyzing-your-projects/#choosing-a-database) on codeql.github.com.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think there should be some guidance if the repository doesn't have a database? Also, is there an easy way for users to determine which repos already has one?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think there should be some guidance if the repository doesn't have a database?

Yes, there probably should. I think that belongs in the real VS Code docs though. I'll open a separate issue in github/codeql for that

Also, is there an easy way for users to determine which repos already has one?

You can check per-repo using the REST API (described in https://codeql.github.com/docs/codeql-for-visual-studio-code/analyzing-your-projects/#obtaining-a-local-database) but you can't get an overview of which repos already have dbs. We might add a way to do that later.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. In the future, we can make this better. Being able to search for repos with dbs would be great. I've already spent lots of time looking for a suitable db to download. If I could issue a search, and find repos with dbs that match certain features, it would be helpful.

Copy link
Copy Markdown
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good as-is. CodeQL docs can be updated separately.

@jf205 jf205 merged commit 3d7f303 into main Sep 30, 2022
@jf205 jf205 deleted the lgtm-update branch September 30, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants