Skip to content

Implement rehydration for variant analysis#1621

Merged
norascheuch merged 3 commits intomainfrom
norascheuch/variant-analysis-rehydrate-and-remove-event
Oct 24, 2022
Merged

Implement rehydration for variant analysis#1621
norascheuch merged 3 commits intomainfrom
norascheuch/variant-analysis-rehydrate-and-remove-event

Conversation

@norascheuch
Copy link
Copy Markdown
Contributor

@norascheuch norascheuch commented Oct 18, 2022

Copies remote queries rehydration implementation in remote-queries-manager to be used for variant analysis. Establishes an onVariantAnalysisRemoved for this.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@norascheuch norascheuch requested a review from a team as a code owner October 18, 2022 15:18
koesie10
koesie10 reviewed Oct 19, 2022
View reviewed changes
Comment thread extensions/ql-vscode/src/remote-queries/variant-analysis-manager.ts Outdated
@norascheuch norascheuch requested a review from a team as a code owner October 19, 2022 12:00
@norascheuch norascheuch marked this pull request as draft October 19, 2022 12:02
@norascheuch
Copy link
Copy Markdown
Contributor Author

norascheuch commented Oct 19, 2022 •
edited
Loading

Sorry, I forgot to leave this as a draft. Will implement koesis comment now. Will be done by @shati-patel here

@norascheuch norascheuch mentioned this pull request Oct 19, 2022
Merged
3 tasks
@norascheuch norascheuch force-pushed the norascheuch/variant-analysis-rehydrate-and-remove-event branch 3 times, most recently from 3a2514a to 917eb8a Compare October 19, 2022 14:25
@norascheuch norascheuch marked this pull request as ready for review October 19, 2022 14:45
@norascheuch
Copy link
Copy Markdown
Contributor Author

norascheuch commented Oct 19, 2022

The failing test is not related to my PR.

elenatanasoiu
elenatanasoiu approved these changes Oct 20, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@elenatanasoiu elenatanasoiu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We paired on this, but looks good 👍

robertbrignull
robertbrignull reviewed Oct 20, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor comments but is looking pretty good generally

Comment thread extensions/ql-vscode/src/query-history.ts Outdated
Comment thread extensions/ql-vscode/src/remote-queries/variant-analysis-manager.ts Outdated
@norascheuch norascheuch force-pushed the norascheuch/variant-analysis-rehydrate-and-remove-event branch from c1af59b to b4cd8a2 Compare October 20, 2022 12:05
elenatanasoiu
elenatanasoiu approved these changes Oct 24, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@elenatanasoiu elenatanasoiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

norascheuch and others added 3 commits October 24, 2022 10:40
@norascheuch
Implement rehydration for variant analysis and introduce onRemoveVari…
79bb894 
…antAnalysis event
@norascheuch @robertbrignull
Implement find-method suggestion
4ed0e0f 
Co-authored-by: Robert <robertbrignull@github.com>
@norascheuch @robertbrignull
Implement new filePath method suggestion
1523bab 
Co-authored-by: Robert <robertbrignull@github.com>
@norascheuch norascheuch force-pushed the norascheuch/variant-analysis-rehydrate-and-remove-event branch from b4cd8a2 to 1523bab Compare October 24, 2022 08:40
@norascheuch norascheuch merged commit 88edcaf into main Oct 24, 2022
@norascheuch norascheuch deleted the norascheuch/variant-analysis-rehydrate-and-remove-event branch October 24, 2022 09:47
@elenatanasoiu elenatanasoiu mentioned this pull request Oct 24, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@charisk charisk charisk left review comments

@koesie10 koesie10 koesie10 left review comments

@robertbrignull robertbrignull robertbrignull left review comments

+1 more reviewer

@elenatanasoiu elenatanasoiu elenatanasoiu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

secexp

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@norascheuch @charisk @koesie10 @elenatanasoiu @robertbrignull