Create Storybook add-on for switching VSCode themes#1627
Merged
Conversation
This adds a Storybook add-on that allows you to switch between VSCode theme. It follows the pattern of the [outline](https://github.com/storybookjs/storybook/tree/v6.5.12/addons/outline/src) and [backgrounds](https://github.com/storybookjs/storybook/tree/v6.5.12/addons/backgrounds) add-ons. Unfortunately, it doesn't apply the CSS to just the elements it should be applied to, but globally to the complete preview. This is a limitation of using CSS files rather than setting inline styles on the elements. We might be able to resolve this in the future by extracting the CSS variables from the CSS files, but this is somewhat more involved.
charisk
approved these changes
Oct 21, 2022
Contributor
charisk
left a comment
charisk
left a comment
There was a problem hiding this comment.
Looks good and works! Thank you for doing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a Storybook add-on that allows you to switch between VSCode theme. It follows the pattern of the outline and backgrounds add-ons.
Unfortunately, it doesn't apply the CSS to just the elements it should be applied to, but globally to the complete preview. This is a limitation of using CSS files rather than setting inline styles on the elements. We might be able to resolve this in the future by extracting the CSS variables from the CSS files, but this is somewhat more involved.
Checklist
ready-for-doc-reviewlabel there.