Initial setup around GitHub API mock server#1629
Merged
Conversation
koesie10
approved these changes
Oct 19, 2022
| @@ -0,0 +1,19 @@ | |||
| export function startServer(): void { | |||
Member
There was a problem hiding this comment.
I'm fine with merging it like this, but do you think it would make sense to create a class for this instead so we can more easily track state (and potentially test it)? For example, it would be really useful to keep track of whether the server is listening.
Contributor
Author
There was a problem hiding this comment.
Yeah might as well do it now (I thought it'll likely be a class but didn't want to do it before we had to)!
koesie10
approved these changes
Oct 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the msw package and some initial structure.
Checklist
N/A - internal only.
ready-for-doc-reviewlabel there.