Skip to content

Add loading of mock scenarios#1641

Merged
charisk merged 11 commits intomainfrom
charisk/load-mock-scenario
Oct 24, 2022
Merged

Add loading of mock scenarios#1641
charisk merged 11 commits intomainfrom
charisk/load-mock-scenario

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Oct 21, 2022

Adds a command to load a mock scenario for the mock GitHub API server to replay.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk added the secexp label Oct 21, 2022
@charisk charisk requested a review from koesie10 October 21, 2022 14:27
@charisk charisk requested a review from a team as a code owner October 21, 2022 14:27
Base automatically changed from charisk/husky-fix to main October 21, 2022 14:51
Copy link
Copy Markdown
Member

@koesie10 koesie10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall and a simple test worked.

My biggest concern is not being able to stop a scenario. Should we unload the request handlers when we start a new recording, and also have a command to unload them? I'm fine with implementing that in a follow-up PR as well.

Comment thread extensions/ql-vscode/src/pure/files.ts
Comment thread extensions/ql-vscode/src/mocks/request-handlers.ts Outdated
Comment thread extensions/ql-vscode/src/mocks/request-handlers.ts Outdated
Comment thread extensions/ql-vscode/src/mocks/request-handlers.ts Outdated
Comment thread extensions/ql-vscode/src/mocks/request-handlers.ts Outdated
@charisk charisk force-pushed the charisk/load-mock-scenario branch from df13432 to e4be1f4 Compare October 24, 2022 09:43
@charisk
Copy link
Copy Markdown
Contributor Author

charisk commented Oct 24, 2022

My biggest concern is not being able to stop a scenario. Should we unload the request handlers when we start a new recording, and also have a command to unload them? I'm fine with implementing that in a follow-up PR as well.

Sorry I missed this on Friday. I've updated the current PR.

@charisk charisk enabled auto-merge (squash) October 24, 2022 13:54
@charisk charisk disabled auto-merge October 24, 2022 14:41
@charisk charisk force-pushed the charisk/load-mock-scenario branch from 19f7075 to f31eec7 Compare October 24, 2022 14:44
@charisk charisk merged commit 98284d9 into main Oct 24, 2022
@charisk charisk deleted the charisk/load-mock-scenario branch October 24, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants