Conversation
koesie10
reviewed
Oct 21, 2022
Member
koesie10
left a comment
There was a problem hiding this comment.
Looks good overall and a simple test worked.
My biggest concern is not being able to stop a scenario. Should we unload the request handlers when we start a new recording, and also have a command to unload them? I'm fine with implementing that in a follow-up PR as well.
df13432 to
e4be1f4
Compare
Contributor
Author
Sorry I missed this on Friday. I've updated the current PR. |
koesie10
approved these changes
Oct 24, 2022
19f7075 to
f31eec7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a command to load a mock scenario for the mock GitHub API server to replay.
Checklist
N/A:
ready-for-doc-reviewlabel there.