Update mock GitHub API request models to support failures by charisk · Pull Request #1644 · github/vscode-codeql

charisk · 2022-10-21T16:10:24Z

This will allow us to simulate failed requests.

Checklist

N/A - internal only

CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
Issues have been created for any UI or other user-facing changes made by this pull request.
[Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

Update mock GitHub API request models to support failures

aad5441

charisk added the secexp label Oct 21, 2022

charisk requested a review from a team October 21, 2022 16:10

charisk requested a review from a team as a code owner October 21, 2022 16:10

koesie10 approved these changes Oct 24, 2022

View reviewed changes

Comment thread extensions/ql-vscode/src/mocks/gh-api-request.ts

Comment thread extensions/ql-vscode/src/mocks/gh-api-request.ts

Use optional property instead of undefined

1e0c91e

charisk enabled auto-merge (squash) October 24, 2022 07:50

charisk merged commit da63b99 into main Oct 24, 2022

charisk deleted the charisk/gh-api-request-with-failures branch October 24, 2022 08:02