Set variant analysis view title to query name#1681
Merged
Conversation
This will make the creation of a webview panel async to allow the `getPanelConfig` method to be an async function. This will allow us to do some work (like retrieving the variant analysis) in the `getPanelConfig` method.
robertbrignull
approved these changes
Oct 31, 2022
Contributor
robertbrignull
left a comment
robertbrignull
left a comment
There was a problem hiding this comment.
One suggested change but otherwise this LGTM.
I haven't been able to verify it manually because I'm having trouble running my extension, but this change looks fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sets the title of the variant analysis view to
{queryName} - CodeQL Query Results. It does so by retrieving the variant analysis in thegetPanelConfigmethod and updating the title whenever the variant analysis is updated.It's probably easiest to review this commit-by-commit. The actual change for setting the view title is quite small, but we first need to allow
getPanelConfigto return a promise.Checklist
ready-for-doc-reviewlabel there.