Fix ESLint configuration for scripts directory#1684
Merged
Conversation
This will fix linting errors when `lint-staged` is run and there are changed files in the `scripts` directory.
This wil remove the discrepancy between the files on which ESLint is run when `lint-staged` is used and the files that are checked using `npm run lint` and `npm run format`. It will now also include the `.storybook` directory which was previously excluded from the ESLint configuration.
robertbrignull
approved these changes
Oct 31, 2022
Contributor
robertbrignull
left a comment
robertbrignull
left a comment
There was a problem hiding this comment.
Thanks for addressing this quickly 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the two commits: this will fix the configuration for the
scriptsdirectory, but it will also change on which files ESLint is run usingnpm run lintandnpm run formatto ensure we don't encounter the same issue in the future.Checklist
ready-for-doc-reviewlabel there.