Add opening on GitHub of live results variant analyses#1685
Merged
Conversation
This adds the `controllerRepo` field to the `VariantAnalysis` shared type. This is technically a breaking change since the old history won't have this field and all calls on this will fail. However, the feature is not available so this should be fine.
koesie10
force-pushed
the
koesie10/open-live-results-on-github
branch
from
bf4bc3c to
9b9ee44
Compare
This implements the "Open on GitHub" context menu item for live results variant analyses.
koesie10
force-pushed
the
koesie10/open-live-results-on-github
branch
from
9b9ee44 to
847cb13
Compare
charisk
approved these changes
Oct 31, 2022
Contributor
charisk
left a comment
charisk
left a comment
There was a problem hiding this comment.
LGTM, just some minor comments.
| @@ -1214,16 +1214,17 @@ export class QueryHistoryManager extends DisposableObject { | |||
| const { finalSingleItem, finalMultiSelect } = this.determineSelection(singleItem, multiSelect); | |||
|
|
|||
| // Remote queries only | |||
Contributor
There was a problem hiding this comment.
Shall we remove this comment now?
| it('should get the run url for remote query history items', () => { | ||
| const actionsWorkflowRunUrl = getActionsWorkflowRunUrl(remoteQueryHistoryItem); | ||
|
|
||
| expect(actionsWorkflowRunUrl).to.equal(`https://github.com/${remoteQueryHistoryItem.remoteQuery.controllerRepository.owner}/${remoteQueryHistoryItem.remoteQuery.controllerRepository.name}/actions/runs/${remoteQueryHistoryItem.remoteQuery.actionsWorkflowRunId}`); |
Contributor
There was a problem hiding this comment.
(optional) This is a very long line, it'd be nice to break things up a bit e.g. extract some of the item used in the URL into variables.
This removes a comment and makes the test lines shorter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the two separate commits: this adds the
controllerRepoto the sharedVariantAnalysistype and then uses it for constructing the actions workflow run URL.Checklist
ready-for-doc-reviewlabel there.