Merged
Conversation
This "config store" creates a `dbconfig.json` file (if it doesn't yet exist), and reads the file to load the database panel state. Only the database config store should be able to modify the config — the config cannot be modified externally. Co-authored-by: Charis Kyriakou <charisk@users.noreply.github.com>
aeisenberg
reviewed
Nov 1, 2022
koesie10
reviewed
Nov 2, 2022
norascheuch
reviewed
Nov 2, 2022
Contributor
norascheuch
left a comment
norascheuch
left a comment
There was a problem hiding this comment.
One question otherwise lgtm!
norascheuch
reviewed
Nov 2, 2022
norascheuch
approved these changes
Nov 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a database configuration file, which will contain state for the new (hidden) database panel introduced in #1682, e.g. what repo lists you've added, what repos you want to run against...
We've added a new
DatabaseConfigStoreclass, which reads/modifies the config file (dbconfig.json). Nothing else should be able to modify the config, so we return a clone whenever anything callsgetConfig().**note: we tried using
Object.freeze()but that didn't give us the appropriate "deep" clone.In a future PR we'll set up a "watcher" that checks for changes to the config.
See internal linked issue for more details! 🔗
Checklist
N/A - internal only 🍜
ready-for-doc-reviewlabel there.