Implement query history "cancel" option#1715
Merged
elenatanasoiu merged 4 commits intomainfrom Nov 4, 2022
Merged
Conversation
This will allow us to make an API call to cancel a variant analysis.
We're going to add tests to check that we cancel a remote query. We'll need a `.cancel` method to be present on our mock local queries for this.
This also adds tests for cancelling a local query and a remote query. NB: We only cancel queries that are in progress, so the tests check the behaviour both for in progress and not in progress items.
elenatanasoiu
force-pushed
the
elena/cancel-variant-analysis
branch
from
443f773 to
145f0bf
Compare
koesie10
approved these changes
Nov 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it possible to cancel a variant analysis from the query history by right-clicking on it. This will trigger a request to the GitHub API to cancel the workflow run. Once that happens, the variant analysis will be updated via the monitor with a
canceledstate.NB: We only attempt to cancel if the item is in progress.
While we're here we're also adding tests for cancelling local queries and remote queries.
Checklist
ready-for-doc-reviewlabel there.