Skip to content

Conversation

@aeisenberg
Copy link
Contributor

This tests occasionally times out during setup. This change attempts to avoid this problem by increasing the max length of the test.

@elenatanasoiu this fix might be an alternative to #1695.

Checklist

  • [n/a] CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • [n/a] Issues have been created for any UI or other user-facing changes made by this pull request.
  • [n/a] [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

This tests occasionally times out during setup. This change attempts to
avoid this problem by increasing the max length of the test.
@aeisenberg aeisenberg requested a review from a team as a code owner November 7, 2022 23:21
@charisk
Copy link
Contributor

charisk commented Nov 8, 2022

Any idea why setting up would take more than 20 seconds? Sounds like a lot!

@aeisenberg
Copy link
Contributor Author

20 seconds was arbitrary. I chose that since we have other tests with a 20s timeout. We can probably go with a shorter timeout, but there are a number of things that take extra time:

  • starting the extension
  • importing a database
  • recursively deleting some files.

@aeisenberg aeisenberg merged commit ab0e8a0 into main Nov 8, 2022
@aeisenberg aeisenberg deleted the aeisenberg/bump-timeouts-in-test branch November 8, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants