Skip to content

Handle failed status in variant analysis view#1728

Merged
koesie10 merged 3 commits intomainfrom
koesie10/failed-view
Nov 10, 2022
Merged

Handle failed status in variant analysis view#1728
koesie10 merged 3 commits intomainfrom
koesie10/failed-view

Conversation

@koesie10
Copy link
Copy Markdown
Member

@koesie10 koesie10 commented Nov 8, 2022

This will show a message for the failure reason in the variant analysis view when the variant analysis has failed.

Screenshot 2022-11-08 at 13 42 38

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

This will show a message for the failure reason in the variant analysis
view when the variant analysis has failed. There don't seem to be
designs for these alerts, but we will need to do a full design review of
the view at some point anyway, so I don't think the exact text is
important.
@koesie10 koesie10 added the secexp label Nov 8, 2022
@koesie10 koesie10 requested a review from a team as a code owner November 8, 2022 12:25
Copy link
Copy Markdown
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@koesie10 koesie10 merged commit 03e48b7 into main Nov 10, 2022
@koesie10 koesie10 deleted the koesie10/failed-view branch November 10, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants