Skip to content

Handle failed result download in view#1729

Merged
koesie10 merged 1 commit intomainfrom
koesie10/failed-download-view
Nov 9, 2022
Merged

Handle failed result download in view#1729
koesie10 merged 1 commit intomainfrom
koesie10/failed-download-view

Conversation

@koesie10
Copy link
Copy Markdown
Member

@koesie10 koesie10 commented Nov 8, 2022

We were not yet showing any errors when a result download had failed. This adds a warning icon to any repositories for which the download has failed and allow expanding the item to show an alert.

Screenshot 2022-11-08 at 13 42 06

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

We were not yet showing any errors when a result download had failed.
This adds a warning icon to any repositories for which the download has
failed and allow expanding the item to show an alert.
@koesie10 koesie10 added the secexp label Nov 8, 2022
@koesie10 koesie10 requested a review from a team as a code owner November 8, 2022 12:42
@koesie10 koesie10 merged commit a239899 into main Nov 9, 2022
@koesie10 koesie10 deleted the koesie10/failed-download-view branch November 9, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants