Split flows for running remote queries#1749
Merged
Conversation
This removes the `runRemoteQuery` method and instead moves all logic specific to remote queries/variant analysis to the remote queries manager and variant analysis manager respectively. This will make it easier to completely remove the remote queries manager in the future.
charisk
approved these changes
Nov 11, 2022
| } | ||
|
|
||
| async function runRemoteQueriesApiRequest( | ||
| export async function runRemoteQueriesApiRequest( |
Contributor
There was a problem hiding this comment.
Can this and buildRemoteQueryEntity be moved to the RemoteQueriesManager too?
Member
Author
There was a problem hiding this comment.
Yes, these can be moved out of this file. I'd prefer to not place them into the RemoteQueriesManager itself since it doesn't depend on the state of that class, but I'll move the buildRemoteQueryEntity into remote-query.ts and create a new file for this method in remote-queries-api.ts.
The `runRemoteQuery` and `runVariantAnalysis` were returning values which were only used in tests. This removes them and replaces the tests by expectations on the commands called by the methods.
This moves some of the code that is specific to remote queries out of the `run-remote-query.ts` file and instead places it in separate files that only deal with remote queries, rather than also dealing with variant analyses.
Base automatically changed from
koesie10/reduce-nesting-remote-query
to
main
November 11, 2022 13:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the
runRemoteQuerymethod and instead moves all logic specific to remote queries/variant analysis to the remote queries manager and variant analysis manager respectively. This will make it easier to completely remove the remote queries manager in the future.Checklist
ready-for-doc-reviewlabel there.