Add support for local dbs in config#1751
Conversation
charisk
left a comment
charisk
left a comment
There was a problem hiding this comment.
Looking good so far, just some small comments!
| name: string; | ||
| dateAdded: number; | ||
| language: string; | ||
| path: string; |
There was a problem hiding this comment.
How about storagePath instead?
| local: { | ||
| lists: config.local.lists.map((list) => ({ | ||
| name: list.name, | ||
| databases: list.databases.map((db) => ({ |
There was a problem hiding this comment.
I think this would work too:
databases: list.databases.map((db) => ({ ...db }));| "name": "foo/bar", | ||
| "dateAdded": 1668096745193, | ||
| "language": "go", | ||
| "path": "Uri to db in workspace storage" |
There was a problem hiding this comment.
I guess it could just be the file system path rather than a URI? What do we store currently?
There was a problem hiding this comment.
We currently store a Uri:
We could change to a file system path, but I wonder if that would make it harder to integrate with existing stuff?
There was a problem hiding this comment.
Hmm Uri is a VS Code thing so I'm thinking we should stick to filesystem paths. We can easily translate to vscode.Uri by doing vscode.Uri.file('/path/to/dir').
There was a problem hiding this comment.
Ah, good point. Will change that 👍🏽
shati-patel
force-pushed
the
shati-patel/local-db-config
branch
from
7eccfb8 to
9db9e7e
Compare
|
I'm going to add some more local cases to the tests, and then I'll take this out of draft :) |
2 participants
Adds support for local databases the config for the new databases panel. Note: this only changes the config - we don't yet render the local items (that's a follow-up issue).
See internal issue for context!
Checklist
N/A - internal only 🖌️
ready-for-doc-reviewlabel there.