Skip to content

Add copying of repository list for variant analyses#1753

Merged
koesie10 merged 2 commits intomainfrom
koesie10/copy-repo-list
Nov 14, 2022
Merged

Add copying of repository list for variant analyses#1753
koesie10 merged 2 commits intomainfrom
koesie10/copy-repo-list

Conversation

@koesie10
Copy link
Copy Markdown
Member

This adds the ability to copy the repository list for variant analyses from the context menu in the query history.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

This adds the ability to copy the repository list for variant analyses
from the context menu in the query history.
@koesie10 koesie10 marked this pull request as ready for review November 11, 2022 15:01
@koesie10 koesie10 requested review from a team as code owners November 11, 2022 15:01
});
});

describe('copyRepoListToClipboard', async () => {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can these tests be in no-workspace or minimal-workspace at all?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think they could be moved to minimal-workspace. However, I don't really see what the advantage would be of splitting these tests over multiple files and test suites. I think it would actually make it harder where something is being tested, although I would also be happy to move them over if there are advantages to that.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that CLI tests are slower (and maybe flakier?) because they have to set up the whole CLI. We generally need to tidy up around the area so I'm happy for us to leave things where they are for now, but I was curious about whether there was a reason we chose to put them here. I guess the reason is that other VariantAnalysisManager tests are in CLI tests.

@koesie10 koesie10 merged commit 6168145 into main Nov 14, 2022
@koesie10 koesie10 deleted the koesie10/copy-repo-list branch November 14, 2022 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants