Merged
Conversation
charisk
reviewed
Nov 14, 2022
Contributor
charisk
left a comment
charisk
left a comment
There was a problem hiding this comment.
Great to see this getting implemented! Just some initial comments from me.
extensions/ql-vscode/test/pure-tests/databases/data/workspace-databases.json
Show resolved
Hide resolved
extensions/ql-vscode/test/pure-tests/databases/db-config-store.test.ts
Outdated
Show resolved
Hide resolved
extensions/ql-vscode/test/pure-tests/databases/db-config-validator.test.ts
Outdated
Show resolved
Hide resolved
norascheuch
force-pushed
the
nora/add-selected-state-to-db-config
branch
from
c2e5df4 to
99d6a6b
Compare
charisk
reviewed
Nov 15, 2022
extensions/ql-vscode/test/pure-tests/databases/db-config-validator.test.ts
Outdated
Show resolved
Hide resolved
norascheuch
force-pushed
the
nora/add-selected-state-to-db-config
branch
from
99d6a6b to
063d870
Compare
charisk
approved these changes
Nov 15, 2022
norascheuch
force-pushed
the
nora/add-selected-state-to-db-config
branch
from
063d870 to
a012d80
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To display selected Databases in the panel we first have to add the attribute to the workspace-databases.json file.
Checklist
ready-for-doc-reviewlabel there.